Add an explicit dance.selections.clear command. #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdoerner
force-pushed
the
clearSelection
branch
from
6945aef to
c152efd
Compare
71
reviewed
Nov 8, 2025
Owner
71
left a comment
71
left a comment
There was a problem hiding this comment.
Thank you! I agree with the idea, just a couple of minor comments.
sdoerner
force-pushed
the
clearSelection
branch
from
c152efd to
ae06916
Compare
This allows using this functionality within environments that prohibit arbitrary code execution (such as certain CSPs). This essentially forks filter() and removes interactive expression selection. Fixes: 71#349
sdoerner
force-pushed
the
clearSelection
branch
from
ae06916 to
81cee59
Compare
sdoerner
commented
Nov 14, 2025
Contributor
Author
sdoerner
left a comment
sdoerner
left a comment
There was a problem hiding this comment.
Thanks for your review. I implemented the requested changes.
Please take another look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using this functionality within environments that prohibit arbitrary code execution (such as certain CSPs).
This essentially forks filter() and removes interactive expression selection.
Fixes: #349