fix minor memory leaks #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are pretty minor: - The one in `editors.ts` only leaks memory until a new editor is opened. - The other one only happens when Dance is disabled. Also fixes iteration of recorder when reaching the start of a buffer. Co-authored-by: Enrico Lumetti <enrico.lumetti@gmail.com>
Owner
Author
|
Change ID in stack1: Footnotes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are pretty minor:
The one in
editors.tsonly leaks memory until a new editor isopened.
The other one only happens when Dance is disabled.
Also fixes iteration of recorder when reaching the start of a buffer.
Co-authored-by: Enrico Lumetti enrico.lumetti@gmail.com