Fix horizontal movement adjustment for Character SelectionBehavior #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71
approved these changes
Dec 14, 2025
Owner
71
left a comment
71
left a comment
There was a problem hiding this comment.
Thank you!
Testing
In the future, if possible please add a test case instead / as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #409
There was already some code in place for adjusting horizontal movement for
SelectionBehavior === Character. It just didn't handle one specific case correctly: whenshift === Shift.Jump && direction === Direction.Forward, the adjustment is also needed. This is fixed in this PR.Testing:
With
SelectionBehavior === Character, check that all horizontal movements (handlwith default keybinds), in all shift modes, work as expected. In particular, try runningblwith extend mode inactive. This was buggy before and is now fixed.