This repository was archived by the owner on Jul 7, 2025. It is now read-only.
ASAP-451 익명 편지 전송 api 추가 #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `send_letter.sender_id`를 nullable로 수정: 도메인, 엔터티, 매퍼 및 DDL 변경. - 익명 편지 생성 팩토리 메서드 `createAnonymous` 추가.
- `send_letter.sender_id` nullable 처리에 따른 조회 로직 수정: 관련 도메인 및 데이터 클래스를 업데이트. - `senderName` 필드를 null 허용하도록 변경. - 테스트 코드에서 null 처리 로직 보완.
- `isSameReceiver` 메서드 수정: 람다를 통한 사용자 객체 생성 대신 직접 `User` 객체를 전달받는 방식으로 변경. - 관련 서비스 로직 리팩토링: 불필요한 람다 호출 제거 및 가독성 향상. - 예외 처리 방식 유지하며 로직 간결화.
Code Coverage Report
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.