This repository was archived by the owner on Jul 7, 2025. It is now read-only.
ASAP-456 비회원 이미지 업로드 로직 추가 및 테스트 보완 #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `userId`를 nullable로 변경하여 비회원 이미지 업로드 지원. - 비회원 업로드 시 기본 ID로 "anonymous" 설정. - `ImageCommandServiceTest` 및 Controller 테스트에 관련 시나리오 추가. - API 문서 변경: 액세스 토큰 필드를 선택사항으로 수정하고 설명 추가.
Code Coverage Report
|
- `ImageMetadata.owner`를 nullable로 변경하여 비회원 지원.
- 비회원 이미지 업로드 시 기본 ID("anonymous") 설정 로직을 `S3ImageManagementAdapter`로 이동.
- `upload` 메서드의 비회원 처리 로직 단순화.
- `ImageCommandServiceTest` 테스트 구조 개선: 시나리오 분리 및 검증 추가.
- `ImageMetadata` 데이터 클래스 구조 수정.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
userId를 nullable로 변경하여 비회원 이미지 업로드 지원.ImageCommandServiceTest및 Controller 테스트에 관련 시나리오 추가.