This repository was archived by the owner on Jul 7, 2025. It is now read-only.
ASAP-461 익명 및 회원 편지 발신자 조회 로직 수정 #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `LetterQueryService`와 `LetterCommandService`에서 `UserManagementPort` 삭제. - `senderName` 기본값 처리 로직 단순화 (`ANONYMOUS_SENDER_NAME` 사용). - 엔터티(`ReceiveLetterEntity`, `SendLetterEntity`)에서 `senderName`을 `sender?.username` 기반으로 계산하도록 수정. - 불필요한 변수와 로직 제거로 코드 최적화.
- 회원 및 비회원 발신자에 대한 이름 처리 로직 추가(`LetterQueryService`). - `UserManagementPort` 의존성 삭제 및 관련 코드 변경. - 발신자가 익명인 경우 "비회원 발신자"로 이름이 표시되도록 수정. - 테스트 케이스 추가 및 기존 테스트 로직 최적화. - `LetterFixture`에 익명 발신자 생성 헬퍼 메서드 추가.
Code Coverage Report
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.