[Design & Refactor] OAuth 통합 레이아웃, 로그인 홈 버튼 UI #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Deploy Previewhttps://lettering-qfe435i9s-yyypearls-projects.vercel.app |
yyypearl
approved these changes
Apr 30, 2025
Comment on lines
+20
to
+35
| <OauthWrapper> | ||
| <OauthButton bgColor="#03CF5D"> | ||
| <Image | ||
| src="/assets/icons/ic_naver.svg" | ||
| alt="Naver" | ||
| width={26} | ||
| height={26} | ||
| /> | ||
| </OauthButton> | ||
| <OauthButton bgColor="#FFFFFF"> | ||
| <SocialGoogle /> | ||
| </OauthButton> | ||
| <OauthButton bgColor="#FEE500"> | ||
| <SocialKakao /> | ||
| </OauthButton> | ||
| </OauthWrapper> |
Contributor
There was a problem hiding this comment.
혹시 여기서 각각의 버튼을 별개의 컴포넌트로 정의해야하는 이유가 있을까? constant로 type(NAVER, GOOGLE, KAKAO), svg, backgroundColor 등을 정의해서 map으로 불러와도 되지 않나 싶어서! 로직도 동일해서 공통의 onClick 함수로 사용해도 좋을 것 같아.
Member
Author
There was a problem hiding this comment.
오호...그게 더 코드 간결성에는 좋겠다..!! 그 생각을 못했네 좋은 의견이야 👍
Contributor
|
응응! env는 수정되면 노션에 업데이트 부탁해! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관 이슈
#163
개요
✅ 작업 내용
🖥 구현 결과
2025-04-29.8.31.55.mov
리뷰 요구사항
/login/authpage와SocialKakao부분이 필요없는 부분도 일부 빼고 변수명 약간 수정이 되어서 그 파트만 확인해주세요~~📝 기타 사항
KEY 명도 각 Auth type에 따라 지정해야해서 수정하는 게 좋을 거 같아요(현재는 카카오 하나라 REST_API_KEY)
이 부분도 배포 설정에서 수정하는 걸로 알고 있는데 나중에 한 번에 수정해줄 수 있는지?
네이밍은 같이 고민해도 좋고, 아님 그냥 수정해서 나중에 노티해주어도 괜찮아요~~