Skip to content

Conversation

@kinderjoypresents
Copy link

@kinderjoypresents kinderjoypresents commented Jan 13, 2026

What changed

Tweaked wallet_requestPermissions to always request eth_accounts too.

Why

A few providers don’t like permission requests without params, so this makes activation a bit more reliable / consistent.

Impact

  • Fewer activation failures on stricter providers
  • More predictable permission request behavior

PR-Codex overview

This PR modifies the request to the provider in the packages/web3-react-agw/src/index.ts file to include parameters for requesting Ethereum accounts. This change aims to ensure that account and chain ID requests are handled serially for better user interaction.

Detailed summary

  • Added params: [{ eth_accounts: {} }] to the wallet_requestPermissions method call.
  • Included a comment explaining the rationale for requesting accounts and chain ID serially.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2026

⚠️ No Changeset found

Latest commit: f758196

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cursor
Copy link

cursor bot commented Jan 13, 2026

PR Summary

Improves activation reliability by explicitly requesting account permissions.

  • In AbstractGlobalWallet.activate, wallet_requestPermissions now includes params: [{ eth_accounts: {} }] before fetching eth_accounts and eth_chainId

Written by Cursor Bugbot for commit f758196. This will update automatically on new commits. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant