Skip to content

Throw error on failed deserializes #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perlkonig merged 1 commit into from
Dec 31, 2025
Merged

Throw error on failed deserializes #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions src/games/frogger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,11 @@ export class FroggerGame extends GameBase {
// using the function for generating random moves.

//The advanced case is handled inside this function, unlike in getNextForward.
const cardObj = Card.deserialize(card)!;

const cardObj = Card.deserialize(card);
if (cardObj === undefined) {
throw new Error(`Could not deserialize the card ${card}`);
}

if (this.variants.includes("advanced") && cardObj.rank.uid !== this.courtrank) {
//In the advanced game, courts still function like regular game cards,
// but number cards do not.
Expand Down Expand Up @@ -468,7 +471,10 @@ export class FroggerGame extends GameBase {
}

private getSuits(cardId: string): string[] {
const card = Card.deserialize(cardId)!;
const card = Card.deserialize(cardId);
if (card === undefined) {
throw new Error(`Could not deserialize the card ${cardId}`);
}
const suits = card.suits.map(s => s.uid);
return suits;
}
Expand Down Expand Up @@ -560,7 +566,11 @@ export class FroggerGame extends GameBase {
const bounced: string[][] = [];

//Bouncing occurs when an Ace or Crown was played, not a number card or a Court.
const card = Card.deserialize(cardId)!;
const card = Card.deserialize(cardId);
if (card === undefined) {
throw new Error(`Could not deserialize the card ${cardId}`);
}

const rank = card.rank.name;
if ( rank === "Crown" || rank === "Ace" ) {

Expand Down Expand Up @@ -852,7 +862,11 @@ export class FroggerGame extends GameBase {
const suit = this.randomElement(suits);

let to;
const cardObj = Card.deserialize(card)!;
const cardObj = Card.deserialize(card);
if (cardObj === undefined) {
throw new Error(`Could not deserialize the card ${card}`);
}

if (this.variants.includes("advanced") && cardObj.rank.uid !== this.courtrank) {
//Courts next forward normally in the advanced game.
//Aces and Crowns do, too, but this function handles them.
Expand Down Expand Up @@ -1639,7 +1653,11 @@ export class FroggerGame extends GameBase {
//add flood and suit markers for the active spaces
for (let col = 1; col < this.columns - 1; col++) {
const cell = this.coords2algebraic(col,0);
const cardObj = Card.deserialize(this.board.get(cell)!);
const card = this.board.get(cell)!;
const cardObj = Card.deserialize(card);
if (cardObj === undefined) {
throw new Error(`Could not deserialize the card ${card}`);
}
const suits = cardObj!.suits;

let shadeRow = 1;
Expand Down