Skip to content

convert special chars to avoid xss #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dneustadt wants to merge 3 commits into
base: main
Choose a base branch
from
Open

convert special chars to avoid xss #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f71f5a
convert special chars to avoid xss
dneustadt May 9, 2021
ad4bf72
more xss fixes
dneustadt May 9, 2021
cdf6714
xss vulnerability fixes
dneustadt May 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions image.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
$loc = "US";

if( isset( $_GET['loc'] ) ) {
$loc = strtoupper($_GET["loc"]);
$loc = urlencode(strtoupper($_GET["loc"]));
}

//get the image url
Expand Down Expand Up @@ -38,9 +38,9 @@
</head>
<body">
<small><a href="<?php echo $_SERVER['HTTP_REFERER'] . '?loc=' . strtoupper($loc) ?>">< Back to article</a></small>
<p><small><b>Viewing image:</b> <?php echo $url ?></small></p>
<img src="/image_compressed.php?i=<?php echo $url; ?>">
<p><small><b>Viewing image:</b> <?php echo htmlspecialchars($url, ENT_QUOTES, 'UTF-8') ?></small></p>
<img src="/image_compressed.php?i=<?php echo urlencode($url); ?>">
<br><br>
<small><a href="<?php echo $_SERVER['HTTP_REFERER'] . '?loc=' . strtoupper($loc) ?>">< Back to article</a></small>
</body>
</html>
</html>
6 changes: 3 additions & 3 deletions index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,12 @@ function clean_str($str) {
<?php if($show_results) { // there's a search query in q, so show search results ?>

<form action="/" method="get">
<a href="/"><font size=6 color="#008000">Frog</font><font size=6 color="#000000">Find!</font></a> Leap again: <input type="text" size="30" name="q" value="<?php echo urldecode($query) ?>">
<a href="/"><font size=6 color="#008000">Frog</font><font size=6 color="#000000">Find!</font></a> Leap again: <input type="text" size="30" name="q" value="<?php echo htmlspecialchars(urldecode($query), ENT_QUOTES, 'UTF-8') ?>">
<input type="submit" value="Ribbbit!">
</form>
<hr>
<br>
<center>Search Results for <b><?php echo strip_tags(urldecode($query)) ?></b></center>
<center>Search Results for <b><?php echo htmlspecialchars(urldecode($query), ENT_QUOTES, 'UTF-8') ?></b></center>
<br>
<?php echo $final_result_html ?>

Expand All @@ -94,4 +94,4 @@ function clean_str($str) {
<?php } ?>

</body>
</html>
</html>
6 changes: 3 additions & 3 deletions read.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
$loc = "US";

if( isset( $_GET['loc'] ) ) {
$loc = strtoupper($_GET["loc"]);
$loc = urlencode(strtoupper($_GET["loc"]));
}

if( isset( $_GET['a'] ) ) {
Expand Down Expand Up @@ -74,7 +74,7 @@ function clean_str($str) {
<body>
<p>
<form action="/read.php" method="get">
<a href="/">Back to <b><font color="#008000">Frog</font><font color="000000">Find!</font></a></b> | Browsing URL: <input type="text" size="38" name="a" value="<?php echo $article_url ?>">
<a href="/">Back to <b><font color="#008000">Frog</font><font color="000000">Find!</font></a></b> | Browsing URL: <input type="text" size="38" name="a" value="<?php echo htmlspecialchars($article_url, ENT_QUOTES, 'UTF-8') ?>">
<input type="submit" value="Go!">
</form>
</p>
Expand All @@ -97,4 +97,4 @@ function clean_str($str) {
<?php if($error_text) { echo "<p><font color='red'>" . $error_text . "</font></p>"; } ?>
<p><font size="4"><?php echo $readable_article;?></font></p>
</body>
</html>
</html>