fix breaking dependency issues introduced in v3.2.0 #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include sourcemap-register.js in build output to resolve missing sourcemap-register.cjs runtime error.
@vercel/ncc generates broken hybrid code when it sees ES modules, causing require is not defined errors
helpful for local debugging
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes breaking dependency issues introduced in v3.2.0 by updating Octokit plugin imports and module configuration. The changes address compatibility problems while adding local development support and error handling improvements.
- Updated Octokit enterprise server plugin from v3.1.2 to v3.1.5 for compatibility
- Removed ES module configuration and switched back to CommonJS format
- Added local development documentation and GITHUB_WORKSPACE validation
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| utils/ActionPolicy.js | Updates Octokit plugin import to use newer enterprise server version |
| readme.md | Adds local development setup instructions with environment variables |
| package.json | Removes ES module type configuration to fix module resolution issues |
| action.js | Adds validation check for GITHUB_WORKSPACE environment variable |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 9 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
stoe
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency updates:
utils/ActionPolicy.jsto useenterpriseServer315Admininstead ofenterpriseServer312Adminfor Octokit plugin compatibility.Configuration changes:
"type": "module"frompackage.json, potentially affecting how modules are resolved. --- @stoe I'm not sure if there is a better way here or not but after iterating a bit, this was the only working solution I could get without downgrading packages.Committing missing file:
sourcemap-register.js(was.cjsbefore the configuration change above)Local development enhancements:
readme.mdwith instructions and environment variable setup for running the project locally.Error handling improvements:
action.jsto throw an error if theGITHUB_WORKSPACEenvironment variable is not set, improving robustness.I tested and validated ✅ that this works here: https://github.com/joshjohanning-org/actions-allow-list-as-code/actions/runs/18046136436/job/51357225375#step:6:1