Upstream merge #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validation after graph search assumes missing transactions to be invalid. This assumption must be reverted before proceeding with the next validation because some skipped transactions from the previous validation may have been non-contributing valid slp transactions. Since reverting a graph node's validity back to unknown state is far to difficult to manage we just save the valid txids to a new cache and reset the whole graph with the internal cache of valid txids.
Now we are using a new go-like WaitGroup class to manage the validation of NFT1 children which requires validation of NFT parents before the NFT can be validated. The NFT1 validator uses `self.wg.wait()` to allow NFT genesis and group parent download threads to complete before continuing with the NFT validation.
* improve gs cache strategy * revert a check in add_job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.