Queues == Emma, Anna, Tehut -- Video Store

[tehut]

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	We looked at the seed data, talked about it then drew it.
List all the completed endpoints of your application.	get "movies", to: "movies#index", as: "movies", get "movies/:title", to: "movies#show", as: "movie", post "/movies", to: 'movies#create', get '/customers', to: 'customers#index', as: 'customers' , post '/rentals/:title/check-out', to: 'rentals#check-out', as: 'check-out'
Describe a set of positive and negative test cases you implemented for a model.	We did not get to the semi-optional so our model methods are not particularly complicated. However we did do pass and fail values for our validations on the models.
Describe a set of positive and negative test cases you implemented for a controller.	We gave the controller good movie data and bad movie data to test that the bad datat wasn't added to the database.
How does your API respond when bad data is sent to it?	It does sends a bad_request status code and does not add the information.
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	We did not write custom methods except to return either 0 (for checkouts) or self.inventory to return available inventory.
Do you have any recommendations on how we could improve this project for the next cohort?	Nope, just having more time in the week and our group had less time because of how we chose to use our friday.
Link to Trello	https://trello.com/b/SvpgW9eL/videostoreapi
Link to ERD	WILL update PR with ERD template ASAP

[droberts-sea]

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes
General
Business Logic in Models	yes (as much as makes sense, mostly via validations)
All 3 required endpoints return expected JSON data	yes
Requests respond with appropriate HTTP Status Code	mostly - your MoviesController#show always responds with a 404
Errors are reported	no - When there's a problem, in addition to sending back a HTTP status code your API should send back some JSON with a list of errors, so that the client can understand what went wrong and correct their behavior. See the "Error Handling" section under "Wave 2" in the project README for an example of what this might look like.
Testing
Passes all Smoke Tests	no (2 failures)
Model Tests - all relations, validations, and custom functions test positive & negative cases	yes
Controller Tests - URI parameters and data in the request body have positive & negative cases	yes
Optionals
POST routes use URI parameter and request body to add a new record to the database	N/A
GET /customers shows how many movies are checked out by a customer	N/A
GET /movies/:title shows updated inventory	N/A
Overall

Good work overall. There's some room for improvement around error handling, but in general I'm quite happy with this.

Note: Your validations did not pass on your seed data!