Janice's VideoStoreAPI (hardly a symphony)

[janicewilson]

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	Reviewed the seed data for potential interactions, then designed accordingly.
List all the completed endpoints of your application.	/customers, /movies/:title, /movies
Describe a set of positive and negative test cases you implemented for a model.	Could create a customer if name was a duplicate, but phone number and postal code were different. Couldn't create a customer if all three were the same.
Describe a set of positive and negative test cases you implemented for a controller.	Couldn't retrieve a movie that wasn't in the database. Could retrieve a movie that was in the database.
How does your API respond when bad data is sent to it?	404
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	Haven't any custom models.
Do you have any recommendations on how we could improve this project for the next cohort?	None.
Link to Trello	Abandoned. But, https://trello.com/b/8Qbtgnp1/wetflix
Link to ERD	Created via Keynote.

[kariabancroft]

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good
Comprehension questions	Yes
General
Business Logic in Models	Not really
All 3 required endpoints return expected JSON data	Yes
Requests respond with appropriate HTTP Status Code	Yes
Errors are reported	Yes
Testing
Passes all Smoke Tests	Yes?
Model Tests - all relations, validations, and custom functions test positive & negative cases	The use of the before block to set the instance variable is fine, but since there is only one test, this is more work than you need. Otherwise, the more specific tests look good.
Controller Tests - URI parameters and data in the request body have positive & negative cases	Looks good
Optionals
POST routes use URI parameter and request body to add a new record to the database	N/A
GET /customers shows how many movies are checked out by a customer	N/A
GET /movies/:title shows updated inventory	N/A
Overall	Looks good