Skip to content

Conversation

@josh-tracey
Copy link
Contributor

No description provided.

josh-tracey and others added 2 commits May 25, 2025 08:58
This commit significantly overhauls the OpenSSL dependency handling for macOS builds in the GitHub Actions release workflow, specifically addressing issues you encountered during cross-architecture compilation (e.g., building for x86_64 on an ARM64 runner).

Key changes to the macOS steps:
- Dynamically determines the target architecture (x86_64 or ARM64) for OpenSSL.
- Uses `arch -x86_64` with Homebrew commands when targeting x86_64 to ensure the correct version of OpenSSL is installed and queried, utilizing Rosetta 2 on ARM64 runners.
- Sets `OPENSSL_DIR` to the precise Homebrew prefix of the architecture-specific OpenSSL installation.
- Sets target-specific environment variables (e.g., `X86_64_APPLE_DARWIN_OPENSSL_DIR`, `AARCH64_APPLE_DARWIN_OPENSSL_DIR`) that the `openssl-sys` crate explicitly checks.
- Prepends the correct OpenSSL `lib/pkgconfig` directory to `PKG_CONFIG_PATH` to guide `pkg-config` if it's used.
- Includes more robust error checking for Homebrew prefix resolution.

These changes are intended to resolve persistent OpenSSL build failures on macOS by ensuring that the build process can reliably locate the appropriate OpenSSL libraries and headers for the specified target architecture.
@vercel
Copy link

vercel bot commented May 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sailr ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2025 11:29am

@josh-tracey josh-tracey merged commit 4329d67 into main May 25, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants