fix: Further refine OpenSSL and Homebrew handling for macOS #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit provides additional refinements to the OpenSSL dependency handling for macOS builds in the GitHub Actions release workflow. The changes focus on ensuring the correct Homebrew instance is invoked, especially when cross-compiling or running on a different architecture than the target (e.g., x86_64 target on an ARM64 runner). Key improvements: - Corrected the use of `arch -x86_64` to prevent duplicate invocations. - Implemented more robust detection of the Homebrew executable by checking multiple standard paths for both x86_64 (under Rosetta) and native ARM64 Homebrew installations. - Added error handling if a suitable Homebrew installation cannot be found. - Ensured that `brew update` is attempted but failures are handled gracefully before proceeding with OpenSSL installation. These adjustments aim to fix errors like "arch: Can't find any plists for arch" and improve the overall reliability of OpenSSL-dependent builds on macOS.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides additional refinements to the OpenSSL dependency handling for macOS builds in the GitHub Actions release workflow. The changes focus on ensuring the correct Homebrew instance is invoked, especially when cross-compiling or running on a different architecture than the target (e.g., x86_64 target on an ARM64 runner).
Key improvements:
arch -x86_64to prevent duplicate invocations.brew updateis attempted but failures are handled gracefully before proceeding with OpenSSL installation.These adjustments aim to fix errors like "arch: Can't find any plists for arch" and improve the overall reliability of OpenSSL-dependent builds on macOS.