Skip to content

Make records() defer to select() #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tlloydthwaites wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make records() defer to select() #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec852d6
Update table.rb
tlloydthwaites May 29, 2023
f2f7c32
Update table.rb
tlloydthwaites Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions lib/airtable/table.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
module Airtable

class Table < Resource
# Maximum results per request
LIMIT_MAX = 100

# Fetch all records iterating through offsets until retrieving the entire collection
# all(:sort => ["Name", :desc])
def all(options={})
offset = nil
results = []
begin
options.merge!(:limit => LIMIT_MAX, :offset => offset)
options.merge!(:offset => offset)
response = records(options)
results += response.records
offset = response.offset
Expand All @@ -22,10 +19,8 @@ def all(options={})
# Options: limit = 100, offset = "as345g", sort = ["Name", "asc"]
# records(:sort => ["Name", :desc], :limit => 50, :offset => "as345g")
def records(options={})
options["sortField"], options["sortDirection"] = options.delete(:sort) if options[:sort]
results = self.class.get(worksheet_url, query: options).parsed_response
check_and_raise_error(results)
RecordSet.new(results)
# previous was just a limited version of select()
select(options)
end

# Query for records using a string formula
Expand Down