Add files via upload #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlakdawala-sf
suggested changes
Aug 17, 2021
|
|
||
| enum Role{SuperAdmin,Admin,Subscriber}; | ||
| class model1{ | ||
| ID:number; |
There was a problem hiding this comment.
Variable casing should be camel case
| @@ -0,0 +1,158 @@ | |||
|
|
|||
| enum Role{SuperAdmin,Admin,Subscriber}; | |||
| @@ -0,0 +1,158 @@ | |||
|
|
|||
| enum Role{SuperAdmin,Admin,Subscriber}; | |||
| class model1{ | |||
| }, | ||
| body: JSON.stringify(object) | ||
| }) | ||
| let data = await response.json() |
There was a problem hiding this comment.
Return directly no need to store in a var
| }, | ||
| body: JSON.stringify(object) | ||
| }) | ||
| let data = await response.json() |
| document.getElementById("saveUpdate"+no).style.visibility="visible"; | ||
| document.getElementById("cancelUpdate"+no).style.visibility="visible"; | ||
|
|
||
| var Id=document.getElementById("ID"+no); |
There was a problem hiding this comment.
Use const over var, if reassignment is not being done
| document.getElementById("saveUpdate"+no).style.visibility="visible"; | ||
| document.getElementById("cancelUpdate"+no).style.visibility="visible"; | ||
|
|
||
| var Id=document.getElementById("ID"+no); |
There was a problem hiding this comment.
Var should not be used google about const and let
| }, | ||
| "keywords": [], | ||
| "author": "", | ||
| "license": "ISC" |
There was a problem hiding this comment.
Missing dependencies out here save deps with the --save flag while installing
| //Decorator Function | ||
| function FormatD(fun){ | ||
| return function(no){ | ||
| var id="DateTime"+no; |
There was a problem hiding this comment.
Dont use var and use template strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.