Improve optimization order, so that they apply faster in big CFG's #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
yay CI is faster 🎉 |
Contributor
|
This PR makes the metacompilation process faster, but produces less quality code. I pushed some results of metacompilation to analyze. In a quick check I identified:
This needs more work yet |
What seems to have happened is that `DRBranchCollapse` was collapsing the getConditionCode's before `DRCogitCanonicaliser>>#visitGetConditionCode:` could do its thing. With this change, I think the generated code should be as good as before Pushing to check how fast it runs in CI
…) into TestNoMask(a, b) and so on for conditions in DRBranchIfCondition, as it already did with DRGetConditionCode
m-demare
force-pushed
the
improve-opt-order
branch
from
3b9f2e2 to
e870676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more of the low-cost/high-reward optimizations at the beggining, simplifying the CFG for the latter, more expensive optimizations, greatly reduces total compile time
With this change, #primitiveAtPut compiles about 1.5 min faster