Fix lint and docker-build: sprintf→snprintf + add libmicrohttpd #228
+12
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two CI issues:
1. Lint fix (sprintf → snprintf):
Replaces unsafe
sprintfcalls withsnprintfto satisfy the CI lint check that flags printf-family functions as potentially unsafe. This is a mechanical change with no functional impact.Files changed:
src/mxd_http_api.c- 5 sprintf → snprintf replacements for block hash and address hex conversionsrc/blockchain/mxd_rsc.c- 4 sprintf → snprintf replacements for genesis address loggingAll buffer sizes are verified correct:
2. Docker build fix:
Adds missing
libmicrohttpddependency that was causing docker-build CI to fail with "No package 'libmicrohttpd' found".Dockerfile changes:
libmicrohttpd-devlibmicrohttpd12andcurl(curl needed for existing healthcheck)Review & Testing Checklist for Human
3is correct for the"%02x"format (writes 2 chars + null per byte)Test plan:
docker build .locally and verify the image startsNotes
Link to Devin run: https://app.devin.ai/sessions/f0a6357d898e440ea3745d77dfb91d8d
Requested by: Runo (runonetworks@gmail.com) / @AlanRuno