Skip to content

protect configurable fixed width axes against wrong ranges #14917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mario-krueger wants to merge 1 commit into
base: dev
Choose a base branch
from
+4 −1
Open

protect configurable fixed width axes against wrong ranges #14917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Framework/Core/include/Framework/HistogramSpec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,10 @@ struct AxisSpec {
}
if (binEdges[0] != VARIABLE_WIDTH) {
nBins = static_cast<int>(binEdges[0]);
binEdges.resize(3); // nBins, lowerBound, upperBound, disregard whatever else is stored in vecotr
if (binEdges.size() < 3 || binEdges[1] > binEdges[2]) {
LOG(fatal) << "Defined ill-defined axis";
}
binEdges.resize(3); // nBins, lowerBound, upperBound, disregard whatever else is stored in vector
}
binEdges.erase(binEdges.begin()); // remove first entry that we assume to be number of bins
}
Expand Down