Better string representation of the ObjectNotFoundException (O2-1416)

CMakeLists.txt

@@ -138,6 +138,7 @@ set(TEST_SRCS
   test/TestSystem.cxx
   test/testMemPool.cxx
   test/testTimer.cxx
+  test/testExceptions.cxx
 )
 
 foreach (test ${TEST_SRCS})

include/Common/Exceptions.h

@@ -29,7 +29,10 @@ struct ObjectNotFoundError : virtual ExceptionBase
 {
   const char *what() const noexcept override
   {
-    return "Object not found error";
+    std::string message = "Object not found: ";
+    auto* errinfo = boost::get_error_info<errinfo_object_name>(*this);
+    message += errinfo ? *boost::get_error_info<errinfo_object_name>(*this) : "(object_name not specified)";
+    return strdup(message.c_str());
   }
 };
 

test/testExceptions.cxx

@@ -0,0 +1,50 @@
+#include "../include/Common/Exceptions.h"
+
+#define BOOST_TEST_MODULE Exceptions test
+#define BOOST_TEST_MAIN
+#define BOOST_TEST_DYN_LINK
+#include <cmath>
+#include <boost/test/unit_test.hpp>
+#include <assert.h>
+#include <boost/test/output_test_stream.hpp>
+#include <iostream>
+#include <time.h>
+
+using namespace std;
+using namespace AliceO2::Common;
+using boost::test_tools::output_test_stream;
+
+void foo()
+{
+  BOOST_THROW_EXCEPTION(ObjectNotFoundError() << errinfo_object_name("object1"));
+}
+
+void bar()
+{
+  BOOST_THROW_EXCEPTION(ObjectNotFoundError());
+}
+
+BOOST_AUTO_TEST_CASE(exceptions_test)
+{
+  BOOST_CHECK_THROW(foo(), ObjectNotFoundError);
+
+  try {
+    foo();
+  } catch (ObjectNotFoundError& e) {
+    cout << e.what() << endl;
+    output_test_stream output;
+    output << e.what();
+    BOOST_CHECK( !output.is_empty( false ) );
+    BOOST_CHECK( output.is_equal( "Object not found: object1" ) );
+  }
+
+  try {
+    bar();
+  } catch (ObjectNotFoundError& e) {
+    cout << e.what() << endl;
+    output_test_stream output;
+    output << e.what();
+    BOOST_CHECK(!output.is_empty(false));
+    BOOST_CHECK(output.is_equal("Object not found: (object_name not specified)"));
+  }
+}