Skip to content

Conversation

@teo
Copy link
Member

@teo teo commented Oct 30, 2024

No description provided.

@teo teo requested review from justonedev1 and knopers8 October 30, 2024 11:14
@knopers8
Copy link
Collaborator

I remember that during the last weekly meeting you reported that this approach was not working. Could you explain what was the issue?

Also, could you please document in the commit description what is the motivation here or include the Jira ticket ID?

@teo
Copy link
Member Author

teo commented Oct 30, 2024

I remember that during the last weekly meeting you reported that this approach was not working. Could you explain what was the issue?

Also, could you please document in the commit description what is the motivation here or include the Jira ticket ID?

Yes, sure. The issue was that FairMQ requires a specific syntax to express an abstract namespace socket name. Giulio advised me on this syntax. I've tested it on staging and it works.

The motivation is https://its.cern.ch/jira/browse/O2-5457

@knopers8
Copy link
Collaborator

Yes, sure. The issue was that FairMQ requires a specific syntax to express an abstract namespace socket name. Giulio advised me on this syntax. I've tested it on staging and it works.

Aha. In the meeting I understood it did not work.

The motivation is https://its.cern.ch/jira/browse/O2-5457

Thank you. Can you please put the "O2-5457" in the commit description? It doesn't have to be the title, but just anywhere so it is trackable via git blame?

knopers8
knopers8 previously approved these changes Oct 30, 2024
@teo teo changed the title [core] Pass to FairMQ tasks abstract namespace endpoint paths DO NOT MERGE BEFORE HI [core] Pass to FairMQ tasks abstract namespace endpoint paths Oct 31, 2024
@teo teo changed the title DO NOT MERGE BEFORE HI [core] Pass to FairMQ tasks abstract namespace endpoint paths [core] Pass to FairMQ tasks abstract namespace endpoint paths Nov 25, 2024
@teo teo requested a review from knopers8 November 25, 2024 11:15
@teo teo merged commit acfe0c8 into master Nov 25, 2024
2 checks passed
@teo teo deleted the o2ipc-abstract branch November 25, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants