Skip to content

[core] Report to Kafka source state if transition failed #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teo merged 1 commit into from
Nov 29, 2024
Merged

[core] Report to Kafka source state if transition failed #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/environment/environment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,13 +413,15 @@ func newEnvironment(userVars map[string]string, newId uid.ID) (env *Environment,

env.handlerFunc()(e)

eventState := e.Dst // we set the destination state here instead of the current for the event write, if the tasks have transitioned
if e.Err != nil {
errorMsg = e.Err.Error()
eventState = e.Src
}

the.EventWriterWithTopic(topic.Environment).WriteEvent(&pb.Ev_EnvironmentEvent{
EnvironmentId: env.id.String(),
State: e.Dst, // exceptionally we take the destination state here instead of the current, because the tasks have transitioned
State: eventState,
RunNumber: env.currentRunNumber,
Error: errorMsg,
Message: "transition step finished",
Expand Down