Several log improvements #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I rearranged two logs correlated to task going to ERROR, with one producing easily-digestible message for an operator.
- shortened one phrase and demoted the log to support, as a similar log is always produced for OPS anyway - removed redundant prefix "deployment error", which IMHO does not add anything to error message which follows (e.g "deployment error error=workflow deployment failed..." becomes "workflow deployment failed...")
knopers8
force-pushed
the
logs-improvements
branch
from
c0c2f83 to
d218d63
Compare
justonedev1
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit descriptions for details.