[core] do not warn about tasks not in roster when it's expected #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scheduling a task kill, we remove it from roster. Thus, when we receive a task state DONE update, there is typically nothing to warn about. OCTRL-940
justonedev1
approved these changes
Jan 16, 2025
teo
approved these changes
Jan 16, 2025
knopers8
added a commit
to knopers8/Control
that referenced
this pull request
Jan 24, 2025
Fixes nil access issue introduced by myself in AliceO2Group#647
knopers8
added a commit
that referenced
this pull request
Jan 31, 2025
Fixes nil access issue introduced by myself in #647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scheduling a task kill, we remove it from roster. Thus, when we receive a task state DONE update, there is typically nothing to warn about.
OCTRL-940