OCTRL-980 Send enabled links to DCS for selected detectors #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCTRL-980 Not yet used by the DCS plugin to send enabled linkIDs for selected detectors, that will come next.
It is activated with '<det>_dcs_send_enabled_links' variable. OCTRL-980
justonedev1
approved these changes
Mar 5, 2025
Collaborator
justonedev1
left a comment
justonedev1
left a comment
There was a problem hiding this comment.
I am approving these with the asterisk that we need to check the DCS communication.
Collaborator
Author
|
Yes, absolutely. We will need to organize a test with Filippo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there are unit tests for the logic to gather the links, communication with DCS remains untested, since I could not see a good way to do it without production. It seems DCS is not available on staging currently.
This being said, the old way of setting active links is preserved, so we can optionally enable the feature in some organized test.