[monitoring] refactor monitoring #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibrary is running
justonedev1
force-pushed
the
refactor_monitoring
branch
from
6e67187 to
72a1b5e
Compare
knopers8
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lately there was a case when internal monitoring wasn't running. So I changed life of internals for the whole time of application, so we don't have to synchronize
StartandStopandSendand just consume. Thanks to this I could drop atomic load in Sending.I also added
WaitUntilRunningmostly for informative purposes it is not 100% necessary for correct function of the library, but it is really helpful for testing.