[Infrastructure] Unlock the power of cppcheck

[vkucera]

In the default configuration, cppcheck (which runs as one of the MegaLinter PR checks) only reports the most critical bugs, such as out of bound access, memory leaks, null pointer dereferences and uninitialised data members. The current codebase has around 90 such reported bugs.
With all checks enabled, cppcheck finds significantly more bugs, potential bugs (such as useless, duplicated, nonsensical, or unreachable code), inefficient code, and many other issues that would otherwise be considered compilation warnings if found by the compiler.
With this configuration, cppcheck has found over 4000 issues in the current codebase among which hundreds are genuine bugs, other hundreds are suspicious constructs (which are likely bugs too), and hundreds more are inefficient constructs.
Despite the high number of true positives the number of false positives stays very low.

EDIT: Instructions for local execution here: AliceO2Group/analysis-framework#313

[github-actions]

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

[victor-gonzalez]

Wow!!!
Can we check the code locally?

[vkucera]

Wow!!! Can we check the code locally?

Yes, if you have cppcheck installed. I am preparing instructions in the Tools section of docs.

[victor-gonzalez]

Wow!!! Can we check the code locally?

Yes, if you have cppcheck installed. I am preparing instructions in the Tools section of docs.

Great!!!
Thanks!!

[vkucera]

Pending discussion on the list of enabled error categories.
In the meantime, the other configuration changes can be merged. #13247

[github-actions]

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.

[github-actions]

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.