Skip to content

Conversation

@akhatun
Copy link
Contributor

@akhatun akhatun commented Oct 4, 2025

Detail descriptions of PWG-UD analysis workflow

Detail descriptions of PWG-UD analysis workflow
@akhatun akhatun marked this pull request as ready for review October 4, 2025 17:43
@akhatun akhatun closed this Oct 4, 2025
@akhatun akhatun reopened this Oct 4, 2025
@akhatun akhatun closed this Oct 4, 2025
@akhatun akhatun reopened this Oct 4, 2025
@akhatun akhatun closed this Oct 4, 2025
Removed additional white spacing
@akhatun akhatun reopened this Oct 4, 2025
@akhatun
Copy link
Contributor Author

akhatun commented Oct 4, 2025

All checks are successful

@akhatun akhatun closed this Oct 4, 2025
@akhatun akhatun reopened this Oct 4, 2025
@ddobrigk ddobrigk merged commit 6cd93c2 into AliceO2Group:master Oct 4, 2025
15 of 17 checks passed
@vkucera
Copy link
Contributor

vkucera commented Oct 4, 2025

All checks are successful

@akhatun No, they were not. Both lychee and markdown-link-check correctly report missing docs/images/UD-Analysis-framework_v2.png.
@ddobrigk Why was it merged despite the failing checks?

@akhatun
Copy link
Contributor Author

akhatun commented Oct 4, 2025

It only complained for Megalinter, not the missing file. the second merge is for the UD-Analysis-framework_v2.png

@vkucera
Copy link
Contributor

vkucera commented Oct 4, 2025

It only complained for Megalinter, not the missing file. the second merge is for the UD-Analysis-framework_v2.png

What do you mean?

  • You said "All checks are successful". MegaLinter is one of the checks and it was not successful.
  • Then you said "It only complained for Megalinter, not the missing file." If you open the MegaLinter log, you'll see that both lychee and markdown-link-check complained about the missing file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants