Skip to content

Feat: Draw geometries on map #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Magnusrm wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Feat: Draw geometries on map #3903

Magnusrm wants to merge 18 commits into from

Conversation

@Magnusrm
Copy link
Contributor

@Magnusrm Magnusrm commented Dec 12, 2025 •
edited
Loading

Description

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

Magnusrm and others added 10 commits October 14, 2025 12:40
@Magnusrm
Feature/3686-draw-on-map (#3785)
b1dc75c 
* Map refactoring

* Implementing reading new optional bindings

* Adding changes to map component from upstream/refactor/map

---------

Co-authored-by: Ole Martin Handeland <git@olemartin.org>
@tina-ahm
Merge branch 'main' into feature/3686-draw-on-map
834424e
@tina-ahm
Feature/toolbar config (#3810)
b703041 
* Add toolbar config

* Add config validation

- Add config validation for geometryIsEditable & toolbar

* Update useValidateGeometriesBindings.ts

- Only check for geometryIsEditable if simpleBinding is not set when geometries are defined

* Update map config validation

- Update useValidateGeometriesBindings to check for geometryIsEditable if toolbar also is set
- Update Map.tsx to only show MapSingleMarker if simpleBinding is set

* Add PR fixes
@tina-ahm
Merge branch 'main' into feature/3686-draw-on-map
a87803c
@Magnusrm
Merge remote-tracking branch 'origin/main' into feature/3686-draw-on-map
efaa8e1
@Magnusrm
Merge remote-tracking branch 'origin/main' into feature/3686-draw-on-map
d0a0808
@Magnusrm
Save-to-datamodel (#3855)
d966b70 
- save to datamodel and load geometries to editable layer
@Magnusrm
Feat/3686-draw-on-map/edit-geometries (#3865)
91f88d8 
* WIP edit geometry

* working editing geometries
@Magnusrm
delete geos wip
2c0faff
@Magnusrm
add WKT support, replace deprecated WKT package
65e2e3a
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 12, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/3686-draw-on-map

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Magnusrm Magnusrm added kind/product-feature Pull requests containing new features backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels Dec 12, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 23, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
16.9% Coverage on New Code (required ≥ 45%)
C Reliability Rating on New Code (required ≥ A)
10.38% Condition Coverage on New Code (required ≥ 45%)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/product-feature Pull requests containing new features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Draw geometries on map component

2 participants

@Magnusrm @tina-ahm