Skip to content

UN-2154 get customers id agreements #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
d-beezee merged 2 commits into from
Dec 4, 2025
Merged

UN-2154 get customers id agreements #492

d-beezee merged 2 commits into from
Dec 4, 2025

Conversation

@Kariamos
Copy link
Contributor

@Kariamos Kariamos commented Dec 3, 2025

No description provided.

@Kariamos Kariamos added core Team Core activity feature labels Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Tests difference:

New Tests

< GET /customers/customerId/agreements - Should answer 200 if logged as user with full access on campaigns
< GET /customers/customerId/agreements - Should answer 200 if logged as user with olps to some owned campaigns
< GET /customers/customerId/agreements - Should answer 403 if customer does not exists
< GET /customers/customerId/agreements - Should answer 403 if logged as user with olps to only other campaigns
< GET /customers/customerId/agreements - Should answer 403 if logged in without permissions
< GET /customers/customerId/agreements - Should answer 403 if not logged in
< GET /customers/customerId/agreements - Should answer with a list of all agreements of the customer if has full access

@coveralls
Copy link
Collaborator

coveralls commented Dec 3, 2025 •
edited
Loading

Coverage Status

coverage: 78.847% (+0.05%) from 78.793%
when pulling 4d72435 on UN-2154-get-customers-id-agreements
into 639b2ee on develop.

@Kariamos Kariamos marked this pull request as draft December 3, 2025 14:06
@Kariamos Kariamos marked this pull request as ready for review December 3, 2025 15:43
@d-beezee
UN-2154 get customers id agreements
94e6dc8 
Modified src/reference/openapi.yml

feat: add endpoint to retrieve agreements for a specific customer

fix: remove unnecessary x-stoplight ID from get customer agreements operation

feat: implement GET endpoint for retrieving customer agreements

refactor: improve access control logic for customer agreements

feat: enhance agreement retrieval logic to include token usage calculations

refactor: refactored methods and retrieval

refactor: streamline customer campaign access checks by separating logic into distinct methods
@d-beezee d-beezee force-pushed the UN-2154-get-customers-id-agreements branch from 4d72435 to 94e6dc8 Compare December 4, 2025 14:46
@d-beezee d-beezee merged commit d4edaf5 into develop Dec 4, 2025
4 checks passed
@d-beezee d-beezee deleted the UN-2154-get-customers-id-agreements branch December 4, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

core Team Core activity feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kariamos @coveralls @d-beezee