Remove setup check for 'magic_quotes' config #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_*' methods are deprecated in php 7.4 and removed in php 8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Setup class currently checks the PHP configuration for the 'magic_quotes' feature to ensure it's turned off. The
get_magic_quotes_gpcandget_magic_quotes_runtimemethods are deprecated in php 7.4 and removed in php 8. This currently causes the installer to fail under PHP 7.4+. The magic_quotes feature was disabled in v5.4, and now the methods to test for it are also being removed, so this check is no longer needed.References:
https://www.php.net/manual/en/function.get-magic-quotes-gpc.php
https://www.php.net/manual/en/function.get-magic-quotes-runtime.php
https://www.php.net/manual/en/migration74.deprecated.php
https://www.php.net/manual/en/migration80.incompatible.php