Change API of primary user-facing functions so that lgt0 and fb are required keyword arguments with no defaults
#108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nglegal, and mc_diffstar_sfh_galpop so that lgt0 and fb are required keyword arguments with no defaults
…input parameters. Make all loss_data scripts now create and accept these two additional parameters.
…star_ssfr_loss_mgash_anyz.py
Contributor
Author
|
Looks like tests pass now. Nice! Do you have a bunch of code elsewhere that will break now? For example, analysis code used to generate the results in the paper that are not part of our test suite? If so, maybe we can proceed to merge anyway, and fix that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change API of primary user-facing functions so that
lgt0andfbare required keyword arguments with no defaults