Skip to content

Conversation

@alexalar
Copy link
Collaborator

This PR combines the model updates from #49 and #48, adding separate main sequence parameters for mseq and qseq galaxies, and also adding an independent frac_quench sigmoid function for centrals and satellites.

…rameters for qseq and mseq galaxies, without offdiagonal covariance elements, and with separate quenching parameters for centrals and satellites.
… to maximize the number of haloes that can be fit at once
@alexalar
Copy link
Collaborator Author

Here are the results for SMDPL. To be compared with:

This is the best version so far, and for the first time we get good sSFR distribution for low mass galaxies at z=0, for both centrals and satellites. The loss function value is also clearly the lowest (20% better) than previous best results.

smhm_logsm
pdf_mstar
pdf_ssfr_centrals
pdf_ssfr_satellites

@alexalar
Copy link
Collaborator Author

Similarly, here are the results for TNG. To be compared with:

The improvements in this case are not so significant. The sSFR of satellites for low mass galaxies at z=0 also get better, but the other differences remain.

smhm_logsm
pdf_mstar
pdf_ssfr_centrals
pdf_ssfr_satellites

@aphearin
Copy link
Collaborator

@alexalar I fixed some bugs in the last few commits. The reason the current PR checks fail is because the test_gradients.py test module fails on account of the parameter u_lgmu_lo_mh_hi having zero-valued gradients. It is possible that the issue is just the way the unit test is written, or it is possible that the issue is with the model formulation, I'm not sure. One way to check would be to check for non-vanishing gradients in the real loss function you are using in your optimizations, and not in this simple toy problem. If you find that theu_lgmu_lo_mh_hi parameter has non-zero gradients when applied to a real problem, then that means this current test failure is harmless, in which case we might should update the gradient test.

@alexalar alexalar mentioned this pull request Jun 16, 2025
@aphearin aphearin merged commit 2d020e8 into main Jun 16, 2025
1 of 2 checks passed
@aphearin aphearin deleted the sepms_satquench branch June 16, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants