[DLFL25]- Possible issues, typos tried to be fixed and comments added where needed to describe the code better #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ong type is more compatible with Torch operations and it can handle larger integers as well
…lib.py for easy readability and understanding
…e for easier understanding
… suggested a fix for a redundant code block in 10-autoencoder.ipynb file
…e style as other comments for easier understanding in 11-VAE.ipynb file
…l_control.ipynb file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried focussing on reducing code redundancy, fixing the scope of possible type mismatches, correcting typos and adding descriptive comments to different code files in this repo (since NYU-DLSP20 has a lot of different open PRs from previous semesters' students that could should have fixed any possible errors there, but there were no open PRs to this repo- so I thought to prioritize it first)