Used Requests package (listed in docs/requirements.txt) to determine … #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LATEST_ACX version in __init__.py to allow download_acx2_emissivity_files() to be called; removed 'import curl'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…LATEST_ACX version in init.py to allow download_acx2_emissivity_files() to be called; removed 'import curl'.
import __init__gave errorModuleNotFoundError: No module named 'curl'. While pycurl is listed as a requirement for pyatomdb, it is not listed for ACX2. Installing pycurl did not resolve, nor curl from condaforge, and it was unclear if another python curl package was intended.ACX2 emissivity files were not being installed by
__init__.pywith setups on two machines including Miniconda3 for both MacOS Intel x86 and macOS Apple Silicon ARM, and having HEASoft setup with PyXspec tested successfully.Retrieved and placed ACX2 emissivity files manually with success. Thought I would propose this change though based on inclusion of
requestspackage in docs/requirements.txtAfter switching to Requests package, calling
pip install -e .inside of the acx2 directory (containing setup.py) successfully installed acx2, and once in the Python interpreter,import acx2_xspecnow lead to ACX2 emissivity files being installed successfully.Edit; formatting, mentioning pycurl