Skip to content

fix(ui): prevent Vite tree-shaking of web mode API URL detection #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itsmylife44 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

fix(ui): prevent Vite tree-shaking of web mode API URL detection #731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions apps/ui/src/lib/http-api-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,12 @@ const getServerUrl = (): string => {
const envUrl = import.meta.env.VITE_SERVER_URL;
if (envUrl) return envUrl;

// In web mode (not Electron), use relative URL to leverage Vite proxy
// In web mode (not Electron), use relative URL to leverage nginx proxy
// This avoids CORS issues since requests appear same-origin
if (!window.electron) {
// Note: Using 'in' operator prevents Vite from tree-shaking this branch,
// as it cannot statically determine the result at build time
const isElectron = 'electron' in window && window.electron != null;
if (!isElectron) {
return '';
}
}
Expand Down