PHPCS fixes and Actions adjusments #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trepmal
commented
Jun 26, 2021
| return static::get_group_for( $name ) == $group; | ||
| } | ||
| } | ||
| if ( ! class_exists( 'CheezTest' ) ) { |
Contributor
Author
There was a problem hiding this comment.
I tried avoiding the class_exists check, but without it I get stuck with the "Missing file doc comment (Squiz.Commenting.FileComment.Missing)" PHPCS feedback. Not sure if a bug in the sniff.
GaryJones
approved these changes
Jun 26, 2021
GaryJones
left a comment
GaryJones
left a comment
There was a problem hiding this comment.
Approved, but with one optional suggestion.
| # continue-on-error: true | ||
| # run: vendor/bin/phpcs --report-full --report-checkstyle=./phpcs-report.xml | ||
| - name: Check PHP code style | ||
| continue-on-error: true |
There was a problem hiding this comment.
As this solves all CS violations, then I would remove this line, so that any changes (either from adjusted code, or fresher versions of PHPCS-related dependencies) get highlighted.
Suggested change
| continue-on-error: true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also removes the PHPUnit setup since I do not expect it will be added in the future.
As the VIP infrastructure no longer relies on Batcache, this is unlikely to be maintained. The aim here is just to leave the plugin in a clean state.