Skip to content

Conversation

@miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

NPPM-2531

Support setting visible paragraphs to zero when configuring the content gate. This means no content should render, and the gate should display immediately.

How to test the changes in this Pull Request:

  1. Make sure you have Woo Memberships and content gate configured
  2. While on release, navigate to Audience -> Configuration -> Content Gating, and edit your gate
  3. Set the gate's "visible paragraphs" to zero
  4. Visit a gated article and confirm the first paragraph renders
  5. Checkout this branch, refresh, and confirm the gate renders without any content

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe self-assigned this Jan 19, 2026
@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 19, 2026
@miguelpeixe miguelpeixe requested a review from a team as a code owner January 19, 2026 19:37
@leogermani
Copy link
Contributor

Will this play (and merge) nicely with #4394 ?

@miguelpeixe
Copy link
Member Author

Yes, but I'll have to move the new file (from #4370). Should be fine.

Copy link
Contributor

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected so I'll approve.

I did have one small non-blocking issue with the appearance of the gate with no excerpt. The ellipses above the gate content seems redundant without any excerpt above it. Do we need it? Or do we need some other type of transition from post header to gate content?

Image

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 22, 2026
@miguelpeixe
Copy link
Member Author

Thanks for the review, @chickenn00dle!

The ellipses above the gate content seems redundant without any excerpt above it.

That's part of the gate content. The editor can remove it if running the gate without any starting content. It's also the case if they configure an overlay gate.

@miguelpeixe miguelpeixe merged commit 56fb741 into release Jan 22, 2026
10 checks passed
@miguelpeixe miguelpeixe deleted the hotfix/content-gate-zero-paragraphs-excerpt branch January 22, 2026 16:11
matticbot pushed a commit that referenced this pull request Jan 22, 2026
## [6.29.1](v6.29.0...v6.29.1) (2026-01-22)

### Bug Fixes

* **content-gate:** support zero paragraph excerpt ([#4408](#4408)) ([56fb741](56fb741))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 6.29.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants