-
Notifications
You must be signed in to change notification settings - Fork 58
fix(content-gate): support zero paragraph excerpt #4408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(content-gate): support zero paragraph excerpt #4408
Conversation
|
Will this play (and merge) nicely with #4394 ? |
|
Yes, but I'll have to move the new file (from #4370). Should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected so I'll approve.
I did have one small non-blocking issue with the appearance of the gate with no excerpt. The ellipses above the gate content seems redundant without any excerpt above it. Do we need it? Or do we need some other type of transition from post header to gate content?
|
Thanks for the review, @chickenn00dle!
That's part of the gate content. The editor can remove it if running the gate without any starting content. It's also the case if they configure an overlay gate. |
## [6.29.1](v6.29.0...v6.29.1) (2026-01-22) ### Bug Fixes * **content-gate:** support zero paragraph excerpt ([#4408](#4408)) ([56fb741](56fb741))
|
🎉 This PR is included in version 6.29.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |

All Submissions:
Changes proposed in this Pull Request:
NPPM-2531
Support setting visible paragraphs to zero when configuring the content gate. This means no content should render, and the gate should display immediately.
How to test the changes in this Pull Request:
release, navigate to Audience -> Configuration -> Content Gating, and edit your gateOther information: