fix(avm): precomp trace for get_p_limbs #19266
Merged
+56
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
IlyasRidhuan
force-pushed
the
ir/12-30-fix_avm_precomp_trace_for_get_p_limbs
branch
from
36e8d0e to
4fc3709
Compare
IlyasRidhuan
requested review from
sirasistant
and removed request for
fcarreiro and
jeanmon
jeanmon
reviewed
Jan 2, 2026
IlyasRidhuan
force-pushed
the
ir/12-27-fix_avm_preserve_coordinates_in_embedded_curve_point
branch
from
75ab6a6 to
280572e
Compare
IlyasRidhuan
force-pushed
the
ir/12-30-fix_avm_precomp_trace_for_get_p_limbs
branch
from
4fc3709 to
e2c018c
Compare
Base automatically changed from
ir/12-27-fix_avm_preserve_coordinates_in_embedded_curve_point
to
merge-train/avm
January 2, 2026 13:54
IlyasRidhuan
force-pushed
the
ir/12-30-fix_avm_precomp_trace_for_get_p_limbs
branch
from
e2c018c to
ebd5e07
Compare
IlyasRidhuan
deleted the
ir/12-30-fix_avm_precomp_trace_for_get_p_limbs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For situations where
radix = 0, 1we were not building the precomputed trace forradix_safe_limbs. Even though theToRadixsubtrace will error (since the radix is invalid). We need this lookup in the execution trace to pass for gas computation.The error was missing by our existing test suite and the to_radix fuzzer becuase the bug only manifests when: