Skip to content

Conversation

@alejoamiras
Copy link
Contributor

We've talked previously of being scared of adding the auto-generation for the release process due to the amount of time it could take; so this PR has performance improvements while also keeping backwards compatibility.

The only real way of improving it was parallelizing it; the only downside it might be that the generated content is no longer deterministic, but I think it's a trade-off we can pay, since links still work, etc.

You can also just use the sequential by setting 1 worker (default mode).

@alejoamiras alejoamiras requested a review from a team December 31, 2025 17:41
@alejoamiras alejoamiras self-assigned this Dec 31, 2025
@alejoamiras alejoamiras changed the base branch from next to fix/parse-additional-comments December 31, 2025 17:41
Copy link
Contributor

@sklppy88 sklppy88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a post step that takes the input at each hierarchical level and sorts it alphabetically so its always deterministic ?

Base automatically changed from fix/parse-additional-comments to merge-train/docs January 1, 2026 18:26
@alejoamiras alejoamiras force-pushed the perf/autogeneration-references branch from 0c50898 to d65ca97 Compare January 2, 2026 14:40
@alejoamiras alejoamiras merged commit 2aff50d into merge-train/docs Jan 2, 2026
12 checks passed
@alejoamiras alejoamiras deleted the perf/autogeneration-references branch January 2, 2026 14:47
@AztecBot AztecBot mentioned this pull request Jan 2, 2026
github-merge-queue bot pushed a commit that referenced this pull request Jan 2, 2026
BEGIN_COMMIT_OVERRIDE
feat(docs): creates networks information page (#19269)
fix(docs): parse additional comments on auto-generating references
(#19270)
feat(docs): improves performance on script for autogenerating the
references (#19271)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants