-
Notifications
You must be signed in to change notification settings - Fork 577
feat(docs): improves performance on script for autogenerating the references #19271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+774
−592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklppy88
approved these changes
Jan 1, 2026
Contributor
sklppy88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a post step that takes the input at each hierarchical level and sorts it alphabetically so its always deterministic ?
Base automatically changed from
fix/parse-additional-comments
to
merge-train/docs
January 1, 2026 18:26
0c50898 to
d65ca97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've talked previously of being scared of adding the auto-generation for the release process due to the amount of time it could take; so this PR has performance improvements while also keeping backwards compatibility.
The only real way of improving it was parallelizing it; the only downside it might be that the generated content is no longer deterministic, but I think it's a trade-off we can pay, since links still work, etc.
You can also just use the sequential by setting 1 worker (default mode).