Skip to content

Conversation

@benesjan
Copy link
Contributor

@benesjan benesjan commented Jan 2, 2026

It has been agreed here to rename *DataProvider as *Store and also to rename SenderAddressBook as SenderAddressBookStore.

Decided to go ahead and just do this change now as AI agents are able to one-shot changes like this.

What is nice that it aligns the naming of KeyStore with the rest. Didn't realized this until implementing this.

Note for reviewing

The diff is huge but all of it is only renaming so I think you can just quickly skim through it.

@benesjan benesjan force-pushed the 01-02-refactor_data_provider_--_store branch from e66edf2 to af9d925 Compare January 2, 2026 18:23
@benesjan benesjan force-pushed the 01-02-refactor_final_tagging_cleanup branch 2 times, most recently from 0be558e to 8e0f190 Compare January 2, 2026 19:20
@benesjan benesjan force-pushed the 01-02-refactor_data_provider_--_store branch from af9d925 to 590b42c Compare January 2, 2026 19:20
@benesjan benesjan marked this pull request as ready for review January 2, 2026 19:46
@benesjan benesjan requested a review from mverzilli January 2, 2026 20:21
Copy link
Contributor

@mverzilli mverzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@AztecBot AztecBot force-pushed the 01-02-refactor_final_tagging_cleanup branch 2 times, most recently from ca6d8c9 to d5184bd Compare January 5, 2026 15:45
Base automatically changed from 01-02-refactor_final_tagging_cleanup to next January 5, 2026 16:20
@benesjan benesjan force-pushed the 01-02-refactor_data_provider_--_store branch from 590b42c to 2692c33 Compare January 5, 2026 16:26
@benesjan benesjan enabled auto-merge January 5, 2026 16:26
@AztecBot
Copy link
Collaborator

AztecBot commented Jan 5, 2026

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (\0338;;http://ci.aztec-labs.com/cc169c8ba149ee5b�cc169c8ba149ee5b8;;�\033):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/add_rollup.test.ts (204s) (code: 1) group:e2e-p2p-epoch-flakes (\033Jan Beneš\033: refactor: data provider --> store (#19290))

@benesjan benesjan added this pull request to the merge queue Jan 5, 2026
Merged via the queue into next with commit efc15ad Jan 5, 2026
17 checks passed
@benesjan benesjan deleted the 01-02-refactor_data_provider_--_store branch January 5, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants