-
Notifications
You must be signed in to change notification settings - Fork 578
refactor: data provider --> store #19290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2026
Contributor
Author
e66edf2 to
af9d925
Compare
0be558e to
8e0f190
Compare
af9d925 to
590b42c
Compare
mverzilli
approved these changes
Jan 5, 2026
Contributor
mverzilli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
ca6d8c9 to
d5184bd
Compare
590b42c to
2692c33
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

It has been agreed here to rename
*DataProvideras*Storeand also to renameSenderAddressBookasSenderAddressBookStore.Decided to go ahead and just do this change now as AI agents are able to one-shot changes like this.
What is nice that it aligns the naming of
KeyStorewith the rest. Didn't realized this until implementing this.Note for reviewing
The diff is huge but all of it is only renaming so I think you can just quickly skim through it.