Skip to content

Update DI to CU converter for GA #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chienyuanchang wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update DI to CU converter for GA #131

chienyuanchang wants to merge 8 commits into from

Conversation

@chienyuanchang
Copy link
Member

@chienyuanchang chienyuanchang commented Jan 16, 2026

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

chienyuanchang
chienyuanchang commented Jan 20, 2026
View reviewed changes
chienyuanchang
chienyuanchang commented Jan 20, 2026
View reviewed changes
aainav269
aainav269 reviewed Jan 21, 2026
View reviewed changes
aainav269
aainav269 reviewed Jan 21, 2026
View reviewed changes
python/di_to_cu_migration_tool/get_ocr.py Outdated

# Set the global variables
api_version = os.getenv("API_VERSION")
api_version = os.getenv("API_VERSION") or CU_API_VERSION
Copy link
Contributor

@aainav269 aainav269 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the os environment doesn't match the api-version?

Copy link
Member Author

@chienyuanchang chienyuanchang Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code will try to get API_VERSION in the env first. If it's none, the program will use default CU_API_VERSION. We can also consider always using the latest default api version instead of letting the user input it.

Copy link
Member Author

@chienyuanchang chienyuanchang Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's only use default CU_API_VERSION since we will always update to the latest version for this tool.

aainav269
aainav269 reviewed Jan 21, 2026
View reviewed changes
python/di_to_cu_migration_tool/get_ocr.py
"Apim-Subscription-id": f"{subscription_key}",
"Content-Type": "application/pdf",
"Ocp-Apim-Subscription-Key": f"{subscription_key}",
"Content-Type": "application/octet-stream",
Copy link
Contributor

@aainav269 aainav269 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we changing the content type while keeping the content the same?

Copy link
Member Author

@chienyuanchang chienyuanchang Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the same content you mentioned. We may have image files. Do we only support pdf files in this tool?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aainav269 aainav269 aainav269 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chienyuanchang @aainav269