Add environment field in the logs to filter logs based on the environment in Dgrep and Kusto #4481
+249
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsreddy
force-pushed
the
mhsreddy/add-environment-logging
branch
from
f5bbbc1 to
8974ae3
Compare
mhsreddy
changed the title
mhsreddy
requested review from
bennerv,
cadenmarchese,
fahlmant,
hawkowl,
hlipsig,
jharrington22,
kimorris27,
mociarain,
mrWinston,
pepedocs,
rogbas,
sankur-codes,
tiguelu,
tsatam,
wanghaoran1988 and
yjst2012
as code owners
mociarain
requested changes
Nov 25, 2025
Member
mociarain
left a comment
mociarain
left a comment
There was a problem hiding this comment.
As I understand it, the ultimate outcome of this will be a mix of prod and staging logs in where we only expect production. I'm not delighted with this but given this is the way HCP is going and the lift needed from MSFT to add Geneva accounts we've decided to mix them. My only request is that we have a way to make this EnvironmentType the first column returned from Kusto by default so people will see this.
If we can't do this I think we need to change our approach
mhsreddy
force-pushed
the
mhsreddy/add-environment-logging
branch
5 times, most recently
from
13f4a64 to
194580f
Compare
… and fluentbit), and metrics to enable filtering and analysis by environment
mhsreddy
force-pushed
the
mhsreddy/add-environment-logging
branch
from
194580f to
d32b772
Compare
hlipsig
approved these changes
Dec 23, 2025
Collaborator
hlipsig
left a comment
hlipsig
left a comment
There was a problem hiding this comment.
Changes LGTM @mociarain will need to confirm since he requested changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes: https://issues.redhat.com/browse/ARO-14708
What this PR does / why we need it:
This PR is to add new environment field in the logs to filter the logs in Kusto or Dgrep. This change enables us to use the production Logging Account in Geneva and filter the logs easily between Production and Stage using the new ENVIRONMENT Field that are injecting.
Test plan for issue:
Tested this in INT, Staging and Canary Environments.
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
The Logs should contain the Environment field in DGREP and Kusto for ARORPLogs, AROClusterLogs