Add environment field in metrics to filter metrics based on the environment in Geneva Monitors and Dashboards #4482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and fluentbit), and metrics to enable filtering and analysis by environment
mhsreddy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes: https://issues.redhat.com/browse/ARO-14708
What this PR does / why we need it:
This PR is to add new extra dimesion Environment to the metrics to include or exclude the metrics in the Geneva Monitors and Metrics. This change enables us to use the production Metrics Account and filter the metrics easily between Prod and stg environment.
Test plan for issue:
Need to Test the changes in INT and Staging Environment First. Make sure that we are able to see the environment in the metrics and also new envitonment field in the logs.
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
The Metrics contain the Environment field in the Geneva Metrics.