arm64 testing and other minor fixes for aasserzo/dev-env-fix #4517
+157
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he doc accordingly
Solving error: --userns and --pod cannot be set together
…detection. Updated secrets targets to source environment variables correctly and handle architecture-specific platform values for containerized development environment.
…struction (line 49), which won't work.
…RET_SA_ACCOUNT_NAME from the env file if not set. This improves robustness in the secrets and secrets-update targets.
…volume path for podman socket to use a default value if XDG_RUNTIME_DIR is not set, and included FEDORA_REGISTRY as a build argument for better flexibility.
…gument for improved flexibility. Removed outdated image update automation from Makefile to streamline the build process.
it was not possible to push an arm64 image to the intsvc CR
On MacOS and docker userns doesn't work as expected. It is more safe to explicitly pass the UID if needed. By symlinking the socket path we could probably use only one path mount here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes failures to install test clusters without hive when running a containerized development RP.
Based on #4509
What this PR does / why we need it:
When using a containerized RP to deploy a cluster, and running a non-hive deployment (local openshift installer container), the RP fails to connect to the hosts podman socket to create the openshift installer.
This PR makes sure the RP container starts with the necessary mounts and permissions to create said installer.
Test plan for issue:
Deploy a cluster against the containerized RP with hive env variables unset.
Is there any documentation that needs to be updated for this PR?
This PR also updates the necessary documentation to make sure users are running podman compose.
How do you know this will function as expected in production?
Not intended for use in production.