MIWI E2E - give FPSP Network Contributor over vnet #4530
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimorris27
requested review from
bennerv,
cadenmarchese,
hawkowl,
hlipsig,
jharrington22,
mociarain,
mrWinston,
pepedocs,
rogbas,
sankur-codes,
tiguelu,
tsatam,
wanghaoran1988 and
yjst2012
as code owners
Contributor
Author
|
Got zonal allocation failures in E2E. I'll try rerunning in a little while. |
Contributor
Author
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
force-pushed
the
kimorris27/ARO-23278-give-fpsp-network-contributor-in-e2e
branch
from
817281a to
59d45b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-23278
What this PR does / why we need it:
CSP E2E already gives the FPSP Network Contributor over the vnet, but MIWI E2E wasn't for some reason. I noticed while working on another task that the only reason MIWI E2E works today is because the FPSP has Owner at subscription scope over the Classic E2E subscription. We should remove that Owner role assignment and rely on properly scoped role assignments.
Test plan for issue:
First, to validate our understanding of the issue:
To test my code changes:
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
Tested in canary.