Removing provisioning of cls, gwy, por, and svc keyvaults #4535
+0
−692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelvweber
requested review from
bennerv,
cadenmarchese,
hawkowl,
hlipsig,
jharrington22,
kimorris27,
mociarain,
mrWinston,
pepedocs,
rogbas,
sankur-codes,
tiguelu,
tsatam,
wanghaoran1988 and
yjst2012
as code owners
rachelvweber
force-pushed
the
rachelvweber/ARO-23286
branch
2 times, most recently
from
25216a6 to
0a546d5
Compare
rachelvweber
force-pushed
the
rachelvweber/ARO-23286
branch
from
0a546d5 to
8efa1c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Part of https://issues.redhat.com/browse/ARO-23286
What this PR does / why we need it:
Removing provisioning of cls, gwy, por, and svc keyvaults from aro-rp. This duplicates the keyvault provisioning in sdp-pipelines. We are trying to migrate to using RBAC, so we want to have the switch be in only one place to make the migration easier
Test plan for issue:
Arm template updates passed all PR Request Validation.
Is there any documentation that needs to be updated for this PR?
No, this is just a removal of duplication configuration.
How do you know this will function as expected in production?
The migration to keyvault RBAC will be a slow roll out with validation at each stage, and we will roll back at any signs of issue.