Luna.ai #20
Open
Luna.ai #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pegasas
force-pushed
the
luna.ai
branch
2 times, most recently
from
12367d4 to
0a37b0b
Compare
fix_delete_judgement
bowgong
reviewed
Jul 23, 2020
|
|
||
| public Guid AADApplicationId { get; set; } | ||
|
|
||
| public string AADApplicationSecrets { get; set; } |
bowgong
reviewed
Jul 23, 2020
| } | ||
|
|
||
| [Key] | ||
| [System.Text.Json.Serialization.JsonIgnore] |
Member
There was a problem hiding this comment.
Remove unnecessary namespace.
Same for below two.
bowgong
reviewed
Jul 23, 2020
| GetABatchInferenceOperation, | ||
| ListAllInferenceOperationsByUser, | ||
| DeployRealTimePredictionEndpoint, | ||
| GetADeployOperationByEndpointIdUser, |
Member
There was a problem hiding this comment.
Naming looks strange, maybe GetDeploy... or GetOneDeploy....?
…m 500 to 409 & some updated comment and error message
Yyh/luna.ai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.